netdev - Re: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181022.193445.1141993426806484413.davem@davemloft.net>
Date:   Mon, 22 Oct 2018 19:34:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     Shahed.Shaikh@...ium.com, sucheta.chakraborty@...gic.com,
        manish.chopra@...ium.com, Dept-GELinuxNICDev@...ium.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] qlcnic: fix a return in qlcnic_dcb_get_capability()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Fri, 19 Oct 2018 23:11:11 +0300

> These functions are supposed to return one on failure and zero on
> success.  Returning a zero here could cause uninitialized variable
> bugs in several of the callers.  For example:
> 
>     drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:1660 get_iscsi_dcb_priority()
>     error: uninitialized symbol 'caps'.
> 
> Fixes: 48365e485275 ("qlcnic: dcb: Add support for CEE Netlink interface.")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.