netdev - Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1540281873.25715.2.camel@realtek.com>
Date:   Tue, 23 Oct 2018 08:05:07 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "zhongjiang@...wei.com" <zhongjiang@...wei.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

On Tue, 2018-10-23 at 13:47 +0800, zhong jiang wrote:
> 'radiob_array_table' and 'radiob_arraylen' is not used after setting its
> value.
> It is safe to remove the unused variable.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> index 5cf29f5..3f33278 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> @@ -509,13 +509,10 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct
> ieee80211_hw *hw,
>  	int i;
>  	bool rtstatus = true;
>  	u32 *radioa_array_table;
> -	u32 *radiob_array_table;
> -	u16 radioa_arraylen, radiob_arraylen;
> +	u16 radioa_arraylen;
>  
>  	radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>  	radioa_array_table = RTL8723E_RADIOA_1TARRAY;
> -	radiob_arraylen = RTL8723E_RADIOB_1TARRAYLENGTH;
> -	radiob_array_table = RTL8723E_RADIOB_1TARRAY;
>  
>  	rtstatus = true;
>  

I think 8723ae has only one antenna, so you can remove radio B array as well.