netdev - Re: [PATCH] r8169: Add new device ID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Oct 2018 14:22:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     shawn.lin@...k-chips.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, hkallweit1@...il.com
Subject: Re: [PATCH] r8169: Add new device ID support

From: Shawn Lin <shawn.lin@...k-chips.com>
Date: Wed, 24 Oct 2018 09:46:47 +0800

> It's found my r8169 ethernet card at hand has a device ID
> of 0x0000 which wasn't on the list of rtl8169_pci_tbl. Add
> a new entry to make it work:
> 
> [2.165785] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> [2.165863] r8169 0000:01:00.0: enabling device (0000 -> 0003)
> [2.167110] r8169 0000:01:00.0 eth0: RTL8168c/8111c at 0xffffff80089be000,
> 00:e0:4c:21:00:17, XID 1c4000c0 IRQ 208
> [2.167128] r8169 0000:01:00.0 eth0: jumbo features [frames: 6128
> bytes, tx checksumming: ko]
> 
> [root@...808:/]# lspci
> 00:00.0 Class 0604: 1d87:1808
> 01:00.0 Class 0200: 10ec:0000
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>

I'm stil not terribly confident in this change, a device ID of zero is
really unusual.

Heiner, what do you think?