netdev - Re: [PATCH net] net: sched: Remove TCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181024.143541.2180259142654512809.davem@davemloft.net>
Date:   Wed, 24 Oct 2018 14:35:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, pupilla@...ero.it, dsahern@...il.com
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

From: David Ahern <dsahern@...nel.org>
Date: Wed, 24 Oct 2018 08:32:49 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Marco reported an error with hfsc:
> root@...imero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> Error: Attribute failed policy validation.
> 
> Apparently a few implementations pass TCA_OPTIONS as a binary instead
> of nested attribute, so drop TCA_OPTIONS from the policy.
> 
> Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
> Reported-by: Marco Berizzi <pupilla@...ero.it>
> Signed-off-by: David Ahern <dsahern@...il.com>

That's unfortunate... applied, thanks.