netdev - Re: [PATCH net-next] tcp: add tcp_reset_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181023.194943.1488187914590113212.davem@davemloft.net>
Date:   Tue, 23 Oct 2018 19:49:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     ncardwell@...gle.com, ycheng@...gle.com, soheil@...gle.com,
        vanj@...gle.com, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: add tcp_reset_xmit_timer() helper

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 23 Oct 2018 11:54:16 -0700

> With EDT model, SRTT no longer is inflated by pacing delays.
> 
> This means that RTO and some other xmit timers might be setup
> incorrectly. This is particularly visible with either :
> 
> - Very small enforced pacing rates (SO_MAX_PACING_RATE)
> - Reduced rto (from the default 200 ms)
> 
> This can lead to TCP flows aborts in the worst case,
> or spurious retransmits in other cases.
> 
> For example, this session gets far more throughput
> than the requested 80kbit :
> 
> $ netperf -H 127.0.0.2 -l 100 -- -q 10000
> MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 127.0.0.2 () port 0 AF_INET
> Recv   Send    Send
> Socket Socket  Message  Elapsed
> Size   Size    Size     Time     Throughput
> bytes  bytes   bytes    secs.    10^6bits/sec
> 
> 540000 262144 262144    104.00      2.66
> 
> With the fix :
> 
> $ netperf -H 127.0.0.2 -l 100 -- -q 10000
> MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 127.0.0.2 () port 0 AF_INET
> Recv   Send    Send
> Socket Socket  Message  Elapsed
> Size   Size    Size     Time     Throughput
> bytes  bytes   bytes    secs.    10^6bits/sec
> 
> 540000 262144 262144    104.00      0.12
> 
> EDT allows for better control of rtx timers, since TCP has
> a better idea of the earliest departure time of each skb
> in the rtx queue. We only have to eventually add to the
> timer the difference of the EDT time with current time.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.