netdev - Re: [PATCH][next] igc: fix error return handling from call to netif_set_real_num_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0080271-fdd5-75fa-6acb-a88eeb7a163b@intel.com>
Date:   Wed, 24 Oct 2018 13:38:57 +0300
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     Colin King <colin.king@...onical.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        intel-wired-lan@...ts.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
        "Neftin, Sasha" <sasha.neftin@...el.com>
Subject: Re: [PATCH][next] igc: fix error return handling from call to
 netif_set_real_num_tx_queues

On 10/19/2018 21:16, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The call to netif_set_real_num_tx_queues is not assigning the error
> return to variable err even though the next line checks err for an
> error.  Fix this by adding the missing err assignment.
> 
> Detected by CoverityScan, CID#1474551 ("Logically dead code")
> 
> Fixes: 3df25e4c1e66 ("igc: Add interrupt support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 9d85707e8a81..80ddbd987764 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -3358,7 +3358,7 @@ static int __igc_open(struct net_device *netdev, bool resuming)
>   		goto err_req_irq;
>   
>   	/* Notify the stack of the actual queue counts. */
> -	netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);
> +	err = netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);
>   	if (err)
>   		goto err_set_queues;
>   
> 
Thanks for the patch. Good catch of my typo.

Acked-by: Sasha Neftin <sasha.neftin@...el.com>