netdev - Re: [net-next 03/11] igc: Add netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d4b0570-6ef4-442b-e2cf-5b7a9c47e226@intel.com>
Date:   Wed, 24 Oct 2018 14:43:25 +0300
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, "Neftin, Sasha" <sasha.neftin@...el.com>
Subject: Re: [net-next 03/11] igc: Add netdev

On 10/18/2018 20:15, Jakub Kicinski wrote:
> On Wed, 17 Oct 2018 15:23:14 -0700, Jeff Kirsher wrote:
>> +/**
>> + * igc_ioctl - I/O control method
>> + * @netdev: network interface device structure
>> + * @ifreq: frequency
> 
> Is it? :)
> 
Ah... Good catch. I will fix that and submit patch.
>> + * @cmd: command
>> + */
>> +static int igc_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
>> +{
>> +	switch (cmd) {
>> +	default:
>> +		return -EOPNOTSUPP;
>> +	}
>> +}
> 
> You don't seem to be adding anything to this function in the series.
> Why add the stub?
> 
Right. Still not in use. I will remove and add per demand.
Thanks for your comments.