netdev - Re: [PATCH net-next v2 1/6] net/ncsi: Don't enable all channels when HWA available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201810241103.hwWXpxHA%fengguang.wu@intel.com>
Date:   Wed, 24 Oct 2018 11:12:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Samuel Mendoza-Jonas <sam@...dozajonas.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        "David S . Miller" <davem@...emloft.net>, Justin.Lee1@...l.com,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org
Subject: Re: [PATCH net-next v2 1/6] net/ncsi: Don't enable all channels when
 HWA available

Hi Samuel,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Samuel-Mendoza-Jonas/net-ncsi-Allow-enabling-multiple-packages-channels/20181024-103206
config: i386-randconfig-x014-201842 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Samuel-Mendoza-Jonas/net-ncsi-Allow-enabling-multiple-packages-channels/20181024-103206 HEAD 54369e39116e3a32a005dd577eba25bd50d15c31 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net/ncsi/ncsi-manage.c: In function 'ncsi_probe_channel':
   net/ncsi/ncsi-manage.c:1129:5: error: implicit declaration of function 'ncsi_enable_hwa'; did you mean 'ncsi_check_hwa'? [-Werror=implicit-function-declaration]
        ncsi_enable_hwa(ndp);
        ^~~~~~~~~~~~~~~
        ncsi_check_hwa
   net/ncsi/ncsi-manage.c: In function 'ncsi_start_dev':
>> net/ncsi/ncsi-manage.c:1575:36: error: passing argument 1 of 'ncsi_choose_active_channel' from incompatible pointer type [-Werror=incompatible-pointer-types]
     return ncsi_choose_active_channel(nd);
                                       ^~
   net/ncsi/ncsi-manage.c:939:12: note: expected 'struct ncsi_dev_priv *' but argument is of type 'struct ncsi_dev *'
    static int ncsi_choose_active_channel(struct ncsi_dev_priv *ndp)
               ^~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/ncsi_choose_active_channel +1575 net/ncsi/ncsi-manage.c

  1560	
  1561	int ncsi_start_dev(struct ncsi_dev *nd)
  1562	{
  1563		struct ncsi_dev_priv *ndp = TO_NCSI_DEV_PRIV(nd);
  1564	
  1565		if (nd->state != ncsi_dev_state_registered &&
  1566		    nd->state != ncsi_dev_state_functional)
  1567			return -ENOTTY;
  1568	
  1569		if (!(ndp->flags & NCSI_DEV_PROBED)) {
  1570			nd->state = ncsi_dev_state_probe;
  1571			schedule_work(&ndp->work);
  1572			return 0;
  1573		}
  1574	
> 1575		return ncsi_choose_active_channel(nd);
  1576	}
  1577	EXPORT_SYMBOL_GPL(ncsi_start_dev);
  1578	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30138 bytes)