netdev - Re: [net-next][PATCH] net/ipv4: fix a net leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92af7409-6154-eb85-7d2f-56f5288b8894@gmail.com>
Date:   Wed, 24 Oct 2018 09:02:15 -0600
From:   David Ahern <dsahern@...il.com>
To:     Li RongQing <lirongqing@...du.com>, netdev@...r.kernel.org
Subject: Re: [net-next][PATCH] net/ipv4: fix a net leak

On 10/24/18 3:36 AM, Li RongQing wrote:
> put net when input a invalid ifindex, otherwise it will be leaked
> 
> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a specific device")
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Zhang Yu <zhangyu31@...du.com>
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> ---
>  net/ipv4/devinet.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index 63d5b58fbfdb..fd0c5a47e742 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -1775,8 +1775,10 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb)
>  
>  		if (fillargs.ifindex) {
>  			dev = __dev_get_by_index(tgt_net, fillargs.ifindex);
> -			if (!dev)
> +			if (!dev) {
> +				put_net(tgt_net);
>  				return -ENODEV;
> +			}
>  
>  			in_dev = __in_dev_get_rtnl(dev);
>  			if (in_dev) {
> 

Good catch. IPv6 has the same problem. Will fix that one.

Reviewed-by: David Ahern <dsahern@...il.com>