netdev - Re: [PATCH net] r8169: fix broken Wake-on-LAN from S5 (poweroff)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181025.161634.598134381939568035.davem@davemloft.net>
Date:   Thu, 25 Oct 2018 16:16:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, neil@...cleod.com
Subject: Re: [PATCH net] r8169: fix broken Wake-on-LAN from S5 (poweroff)

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 25 Oct 2018 18:40:19 +0200

> It was reported that WoL from S5 is broken (WoL from S3 works) and the
> analysis showed that during system shutdown the network interface was
> brought down already when the actual kernel shutdown started.
> Therefore netif_running() returned false and as a consequence the PHY
> was suspended. Obviously WoL wasn't working then.
> To fix this the original patch needs to be effectively reverted.
> A side effect is that when normally bringing down the interface and
> WoL is enabled the PHY will remain powered on (like it was before the
> original patch).
> 
> Fixes: fe87bef01f9b ("r8169: don't check WoL when powering down PHY and interface is down")
> Reported-by: Neil MacLeod <neil@...cleod.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable, thanks.