netdev - Re: [RFC net-next v2 2/8] net: add netif_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK+XE=kLzRrgSEOaWqcrPXBnrYHQ5bjR_OxViqsuy9E6h6r9Sw@mail.gmail.com>
Date:   Thu, 25 Oct 2018 15:59:14 +0100
From:   John Hurley <john.hurley@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        oss-drivers@...ronome.com, Or Gerlitz <gerlitz.or@...il.com>,
        ozsh@...lanox.com, Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Simon Horman <simon.horman@...ronome.com>, avivh@...lanox.com
Subject: Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

On Thu, Oct 25, 2018 at 2:00 PM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Thu, Oct 25, 2018 at 02:26:51PM CEST, john.hurley@...ronome.com wrote:
> >Add a helper function to determine if the type of a netdev is geneve based
> >on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels
> >to check the underlying type of the device.
> >
> >A recent patch added a similar helper to vxlan.h
> >
> >Signed-off-by: John Hurley <john.hurley@...ronome.com>
> >Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>
> I don't understand why this and the next patch are part of this
> patchset. They don't seem directly related.

This is used in later patches that implement the indirect block
offload but I suppose it is not directly related.
We can probably move it to a separate patchset.
Thanks