netdev - Re: [PATCH v3 2/2] net: qcom/emac: add phy-handle support for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181025192430.GA16785@lunn.ch>
Date:   Thu, 25 Oct 2018 21:24:30 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Wang Dongsheng <dongsheng.wang@...-semitech.com>
Cc:     timur@...nel.org, yu.zheng@...-semitech.com, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 2/2] net: qcom/emac: add phy-handle support for ACPI

On Thu, Oct 25, 2018 at 06:09:15PM +0800, Wang Dongsheng wrote:
> Use "phy-handle" to porint an internal MDIO device port.

Hi Dongsheng

You are basically defining how all future ACPI based MAC drivers get
access to their PHY. This needs to become part of the ACPI standard,
etc.

This code should not be hidden away in the emac driver. It needs to be
placed somewhere public so other drivers can use it. And it needs good
documentation, including an example of what needs to go into the ACPI
tables, etc.

Thanks
	Andrew