netdev - Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B2209C1-6FC9-42EA-AA27-9457815797CB@cumulusnetworks.com>
Date:   Fri, 26 Oct 2018 19:26:31 +0300
From:   nikolay@...ulusnetworks.com
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
CC:     Jiri Pirko <jiri@...lanox.com>,
        Linus Lüssing <linus.luessing@...3.blue>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

On 26 October 2018 05:28:43 EEST, Hangbin Liu <liuhangbin@...il.com> wrote:
>Based on RFC 4541, 2.1.1.  IGMP Forwarding Rules
>
>  The switch supporting IGMP snooping must maintain a list of
>  multicast routers and the ports on which they are attached.  This
>  list can be constructed in any combination of the following ways:
>
>  a) This list should be built by the snooping switch sending
>     Multicast Router Solicitation messages as described in IGMP
>     Multicast Router Discovery [MRDISC].  It may also snoop
>     Multicast Router Advertisement messages sent by and to other
>     nodes.
>
>  b) The arrival port for IGMP Queries (sent by multicast routers)
>     where the source address is not 0.0.0.0.
>
>We should not add the port to router list when receives query with
>source
>0.0.0.0.
>
>Reported-by: Ying Xu <yinxu@...hat.com>
>Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
>---

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>