netdev - Re: [PATCH net] net: sched: Remove TCA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWzthb3JoHyMv0AtJZQNVr9CQgkoJ8jOpsZpMSX1R7WKg@mail.gmail.com>
Date:   Fri, 26 Oct 2018 11:19:02 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Marco Berizzi <pupilla@...ero.it>
Cc:     dsahern@...nel.org, David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi <pupilla@...ero.it> wrote:
> Apologies for bothering you again.
> I applied your patch to 4.19, but after issuing this
> command:
>
> root@...imero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
> root@...imero:~# ping 10.81.104.1
> PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data.
> ^C
> --- 10.81.104.1 ping statistics ---
> 2 packets transmitted, 0 received, 100% packet loss, time 1001ms
>
> I'm losing ipv4 connectivity.
> If I remove the qdisc everything is going to work again:

Did this really work before?

You specify a default class without adding it, so the packets are dropped.

How would you expect this to work? :)