netdev - Re: CAKE and r8169 cause panic on upload in v4.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Oct 2018 22:54:12 +0200
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Dave Taht <dave.taht@...il.com>
Cc:     hkallweit1@...il.com,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "David S. Miller" <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiří Pírko 
        <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19

Hi.

On 26.10.2018 22:25, Dave Taht wrote:
> Can you repeat your test, disabling gro splitting in cake?
> 
> the option is "no-split-gso"

Still panics. Takes a couple of rounds, but panics.

Moreover, I've stressed my HTB setup like this too for a longer time, 
and it panics as well. So, at least, now I have a proof this is not a 
CAKE-specific thing.

Also, I've stressed it even with noqueue, and the panic is still there. 
So, this thing is not even sch-specific.

Next, I've seen GRO bits in the call trace and decided to disable GRO on 
this NIC. So far, I cannot trigger a panic with GRO disabled even after 
20 rounds of speedtest.

So, must be some generic thing indeed.

-- 
   Oleksandr Natalenko (post-factum)