netdev - Re: [net:master 17/19] net//bridge/br_multicast.c:1432:32: error: 'union <anonymous>' has no member named 'ip6'; did you mean 'ip4'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90c5f2fe-1743-6b17-2e44-eba58cdbbb35@cumulusnetworks.com>
Date:   Sat, 27 Oct 2018 10:10:50 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     kbuild test robot <lkp@...el.com>,
        Hangbin Liu <liuhangbin@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net:master 17/19] net//bridge/br_multicast.c:1432:32: error:
 'union <anonymous>' has no member named 'ip6'; did you mean 'ip4'?

On 27/10/2018 03:50, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
> head:   aab456dfa404f3a16d6f1780e62a6a8533c4d008
> commit: 5a2de63fd1a59c30c02526d427bc014b98adf508 [17/19] bridge: do not add port to router list when receives query with source 0.0.0.0
> config: powerpc-defconfig (attached as .config)
> compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 5a2de63fd1a59c30c02526d427bc014b98adf508
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=powerpc 
> 
> All errors (new ones prefixed by >>):
> 
>    net//bridge/br_multicast.c: In function 'br_multicast_query_received':
>>> net//bridge/br_multicast.c:1432:32: error: 'union <anonymous>' has no member named 'ip6'; did you mean 'ip4'?
>           !ipv6_addr_any(&saddr->u.ip6)))
>                                    ^~~
>                                    ip4
> 
> vim +1432 net//bridge/br_multicast.c
> 
>   1414	
>   1415	static void br_multicast_query_received(struct net_bridge *br,
>   1416						struct net_bridge_port *port,
>   1417						struct bridge_mcast_other_query *query,
>   1418						struct br_ip *saddr,
>   1419						unsigned long max_delay)
>   1420	{
>   1421		if (!br_multicast_select_querier(br, port, saddr))
>   1422			return;
>   1423	
>   1424		br_multicast_update_query_timer(br, query, max_delay);
>   1425	
>   1426		/* Based on RFC4541, section 2.1.1 IGMP Forwarding Rules,
>   1427		 * the arrival port for IGMP Queries where the source address
>   1428		 * is 0.0.0.0 should not be added to router port list.
>   1429		 */
>   1430		if ((saddr->proto == htons(ETH_P_IP) && saddr->u.ip4) ||
>   1431		    (saddr->proto == htons(ETH_P_IPV6) &&
>> 1432		     !ipv6_addr_any(&saddr->u.ip6)))
>   1433			br_multicast_mark_router(br, port);
>   1434	}
>   1435	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

Should've seen this one coming when reviewing the patch, ip6 is defined
only when IPv6 is configured.
I'll send a fix in a minute after running a few tests.

Thanks.