netdev - Re: CAKE and r8169 cause panic on upload in v4.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a9ff4ac2596869f23e871b40d862802@natalenko.name>
Date:   Sat, 27 Oct 2018 13:04:38 +0200
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Dave Taht <dave.taht@...il.com>
Cc:     hkallweit1@...il.com,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        "David S. Miller" <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiří Pírko 
        <jiri@...nulli.us>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: CAKE and r8169 cause panic on upload in v4.19

Hi.

On 27.10.2018 01:08, Dave Taht wrote:
> Groovy. :whew:
> 
> I do look forward to more cake test results, particularly on different
> network cards such as these, and at speeds higher than 10Gbit on high
> end hardware, and in the 100-1Gbit range on low to mid-range. After
> the last round of features added to cake before it went into linux, we
> run now out of cpu on inbound shaping at those speeds on low end apu2
> (x86) hardware, (atom and a15 chips are not so hot now either) and I
> wish I knew what we could do to speed it up. The new "list skb" and
> mirred code looked promising but we haven't got around to exploring it
> yet.
> 
> Thank you for trying and I hope this gets sorted out on your chipset.

Yeah, but this is still strange. Both LAN computer and router run 4.19, 
but only router panics. The LAN computer employs alx driver, router 
employs r8169. Both had GRO enabled at the moment of panic. But [1] 
reports that this happens with Intel NIC too, so must not be limited to 
Realtek.

> We tend to use flent's rrul test to *really* abuse things. :)
> 
> So cake's ok with gro disabled in hw?

Yes, I've gone back to CAKE but with GRO disabled for NIC, and it is 
stable now. I've also asked a bug reporter [1] to do the same, so we 
will see.

Thanks.

-- 
   Oleksandr Natalenko (post-factum)

[1] https://bugzilla.kernel.org/show_bug.cgi?id=201063