netdev - Re: [PATCH bpf] tools/bpf: add unlimited rlimit for flow_dissector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW60eaD2yanRyMojNggtdUwj_dVOd+DSeE-BOnZaohkYmg@mail.gmail.com>
Date:   Mon, 29 Oct 2018 15:09:55 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     yhs@...com
Cc:     ast@...com, Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, kernel-team@...com
Subject: Re: [PATCH bpf] tools/bpf: add unlimited rlimit for flow_dissector_load

On Mon, Oct 29, 2018 at 2:58 PM Yonghong Song <yhs@...com> wrote:
>
> On our test machine, bpf selftest test_flow_dissector.sh failed
> with the following error:
>   # ./test_flow_dissector.sh
>   bpffs not mounted. Mounting...
>   libbpf: failed to create map (name: 'jmp_table'): Operation not permitted
>   libbpf: failed to load object 'bpf_flow.o'
>   ./flow_dissector_load: bpf_prog_load bpf_flow.o
>   selftests: test_flow_dissector [FAILED]
>
> Let us increase the rlimit to remove the above map
> creation failure.
>
> Signed-off-by: Yonghong Song <yhs@...com>

Acked-by: Song Liu <songliubraving@...com>

> ---
>  tools/testing/selftests/bpf/flow_dissector_load.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/flow_dissector_load.c b/tools/testing/selftests/bpf/flow_dissector_load.c
> index d3273b5b3173..ae8180b11d5f 100644
> --- a/tools/testing/selftests/bpf/flow_dissector_load.c
> +++ b/tools/testing/selftests/bpf/flow_dissector_load.c
> @@ -11,6 +11,8 @@
>  #include <bpf/bpf.h>
>  #include <bpf/libbpf.h>
>
> +#include "bpf_rlimit.h"
> +
>  const char *cfg_pin_path = "/sys/fs/bpf/flow_dissector";
>  const char *cfg_map_name = "jmp_table";
>  bool cfg_attach = true;
> --
> 2.17.1
>