netdev - Re: [PATCH iproute2-next 3/3] rdma: Add an option to rename IB device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7151495-d8ab-209b-a86e-575fc2f4ed53@gmail.com>
Date:   Mon, 29 Oct 2018 11:07:06 -0600
From:   David Ahern <dsahern@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next 3/3] rdma: Add an option to rename IB device
 interface

On 10/29/18 4:30 AM, Leon Romanovsky wrote:
> 
> Sorry for being slow in response, I was on vacation.
> ----------
> 
> This print is intended to warn about missing "new name" and it is not
> checked by rd_exec_require_dev()
> 
> To emphasize it:
> 
> diff --git a/rdma/dev.c b/rdma/dev.c
> index 760b7fb3..468ae686 100644
> --- a/rdma/dev.c
> +++ b/rdma/dev.c
> @@ -246,6 +246,7 @@ static int dev_set_name(struct rd *rd)
>         uint32_t seq;
> 
> 	if (rd_no_arg(rd)) {
> +               pr_err("hello world\n");
>                 pr_err("Please provide device new  name.\n");
> 		return -EINVAL;
> 	}
> 
> Produces the following output:
> [leonro@...ver iproute2]$ ./rdma/rdma dev set mlx5_0 name
> hello world
> Please provide device new name.
> 
> So how will we progress from here? Should I respin?

ok, thanks for the explanation.

Steve mentioned an update to the man page is needed as well. Please do
that in the respin.

Thanks,