netdev - Re: [PATCH net] net: sched: gred: pass the right attribute to gred_change_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181028.192401.1794880879917119232.davem@davemloft.net>
Date:   Sun, 28 Oct 2018 19:24:01 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     tgraf@...g.ch, jhs@...atatu.com, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net] net: sched: gred: pass the right attribute to
 gred_change_table_def()

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 26 Oct 2018 15:51:06 -0700

> gred_change_table_def() takes a pointer to TCA_GRED_DPS attribute,
> and expects it will be able to interpret its contents as
> struct tc_gred_sopt.  Pass the correct gred attribute, instead of
> TCA_OPTIONS.
> 
> This bug meant the table definition could never be changed after
> Qdisc was initialized (unless whatever TCA_OPTIONS contained both
> passed netlink validation and was a valid struct tc_gred_sopt...).
 ...
> Fixes: f62d6b936df5 ("[PKT_SCHED]: GRED: Use central VQ change procedure")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Quite an ancient bug :-)

Applied and queued up for -stable, thanks!