netdev - Re: [PATCH net] net/mlx5e: fix csum adjustments caused by RXFCS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLACBMgvACD=4hMBRMD43HPH9rCwqe=Mii6CQV89v9Mdg@mail.gmail.com>
Date:   Tue, 30 Oct 2018 12:03:26 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Dimitris Michailidis <dmichail@...gle.com>,
        Paweł Staszewski <pstaszewski@...are.pl>
Subject: Re: [PATCH net] net/mlx5e: fix csum adjustments caused by RXFCS

On Tue, Oct 30, 2018 at 11:59 AM Cong Wang <xiyou.wangcong@...il.com> wrote:

> I wonder how compiler recognizes it as "never fail" when marked with
> __must_check.

__must_check means that you can not ignore the return value of a function.

Here we do use the return value.

Also prior code was not checking skb->length so really my patch does
add explicit
check if in the future skb->len gets wrong after a bug is added in this driver.

(A NULL deref will trap the bug, instead of potentially reading
garbage from skb->data)