netdev - Re: [PATCH net v5] net/ipv6: Add anycast addresses to a global hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181029.203211.604037421868394185.davem@davemloft.net>
Date:   Mon, 29 Oct 2018 20:32:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     0xeffeff@...il.com
Cc:     netdev@...r.kernel.org, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net v5] net/ipv6: Add anycast addresses to a global
 hashtable

From: Jeff Barnhill <0xeffeff@...il.com>
Date: Sun, 28 Oct 2018 01:51:59 +0000

> +struct ipv6_ac_addrlist {
> +	struct in6_addr		acal_addr;
> +	possible_net_t		acal_pnet;
> +	refcount_t		acal_users;
> +	struct hlist_node	acal_lst; /* inet6_acaddr_lst */
> +	struct rcu_head		rcu;
> +};

Please just add the hlist to ifcaddr6 instead of duplicating so much
information and reference counters here.

This seems to waste a lot of memory unnecessary and add lots of
unnecessary object allocate/setup/destroy logic.