netdev - Re: [PATCH net] net/mlx4_en: add a missing <net/ip.h> include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b11fea29-ef5b-b336-551b-9a1d16a1964f@mellanox.com>
Date:   Wed, 31 Oct 2018 11:46:47 +0000
From:   Tariq Toukan <tariqt@...lanox.com>
To:     "edumazet@...gle.com" <edumazet@...gle.com>,
        "abdhalee@...ux.vnet.ibm.com" <abdhalee@...ux.vnet.ibm.com>
CC:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        "eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net/mlx4_en: add a missing <net/ip.h> include



On 30/10/2018 8:19 PM, David Miller wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> Date: Tue, 30 Oct 2018 00:18:12 -0700
> 
>> Abdul Haleem reported a build error on ppc :
>>
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: `struct
>> iphdr` declared inside parameter list [enabled by default]
>>             struct iphdr *iph)
>>                    ^
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: its scope is
>> only this definition or declaration, which is probably not what you want
>> [enabled by default]
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c: In function
>> get_fixed_ipv4_csum:
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c:586:20: error: dereferencing
>> pointer to incomplete type
>>    __u8 ipproto = iph->protocol;
>>                      ^
>>
>> Fixes: 55469bc6b577 ("drivers: net: remove <net/busy_poll.h> inclusion when not needed")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> 
> Applied, thanks Eric.
> 

Thanks for the report, Abdul Haleem.
Thanks for your patch, Eric.

Regards,
Tariq