netdev - Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181031134436.GH194472@sasha-vm>
Date:   Wed, 31 Oct 2018 09:44:36 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Eduardo Valentin <eduval@...zon.com>
Cc:     David Miller <davem@...emloft.net>, gregkh@...uxfoundation.org,
        cpaasch@...le.com, netdev@...r.kernel.org, stable@...r.kernel.org,
        stephen@...workplumber.org, luqia@...zon.com, edumazet@...gle.com,
        soheil@...gle.com, weiwan@...gle.com, willemb@...gle.com
Subject: Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing
 from the rbtree

On Tue, Oct 30, 2018 at 12:12:51PM -0700, Eduardo Valentin wrote:
>Greg,
>
>On Thu, Oct 18, 2018 at 03:43:48PM -0700, David Miller wrote:
>> From: Christoph Paasch <cpaasch@...le.com>
>> Date: Thu, 18 Oct 2018 13:38:40 -0700
>>
>> > Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got
>> > backported as commit 6b921536f170 ("net: sk_buff rbnode reorg") into the
>> > v4.14.x-tree.
>> >
>> > However, the backport does not include the changes in sch_netem.c
>> >
>> > We need these, as otherwise the skb->dev pointer is not set when
>> > dequeueing from the netem rbtree, resulting in a panic:
>>  ...
>> > Fixes: 6b921536f170 ("net: sk_buff rbnode reorg")
>> > Cc: Stephen Hemminger <stephen@...workplumber.org>
>> > Cc: Eric Dumazet <edumazet@...gle.com>
>> > Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
>> > Cc: Wei Wang <weiwan@...gle.com>
>> > Cc: Willem de Bruijn <willemb@...gle.com>
>> > Signed-off-by: Christoph Paasch <cpaasch@...le.com>
>> > ---
>> >
>> > Notes:
>> >     This patch should only make it into v4.14-stable as that's the only branch where
>> >     the offending commit has been backported to.
>>
>> Greg, please queue up.
>
>Are you planing to queue this one ?
>
>Looks to me it was a miss on the backport.
>
>It seams that the backport was touching different files, and missed the change
>on net/sched/sch_netem.c. So, to me, even if this patch may not follow the
>strictly the rules of stable, as it is not a patch in upstream, seams to be a
>needed change, even if it is specific to stable linux-4.14.y.

I've queued this patch for 4.14.

--
Thanks,
Sasha