netdev - Re: [PATCH iproute2] Use libbsd for strlcpy if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181031080922.2ff123eb@xeon-e3>
Date:   Wed, 31 Oct 2018 08:09:22 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Luca Boccassi <bluca@...ian.org>
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH iproute2] Use libbsd for strlcpy if available

On Mon, 29 Oct 2018 10:46:50 +0000
Luca Boccassi <bluca@...ian.org> wrote:

> If libc does not provide strlcpy check for libbsd with pkg-config to
> avoid relying on inline version.
> 
> Signed-off-by: Luca Boccassi <bluca@...ian.org>
> ---
> This allows distro maintainers to be able to choose to reduce
> duplication and let this code be maintained in one place, in the
> external library.
> 

I like the idea, but it causes warnings on Debian testing, and maybe other distros.

ipnetns.c:2: warning: "_ATFILE_SOURCE" redefined
 #define _ATFILE_SOURCE
 
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/string.h:26,
                 from /usr/include/bsd/string.h:30,
                 from <command-line>:
/usr/include/features.h:326: note: this is the location of the previous definition
 # define _ATFILE_SOURCE 1


Please figure out how to handle this and resubmit.  SUSE open build service might
also work to test multiple distro's