netdev - Re: [PATCH iproute] ss: Actually print left delimiter for columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181031083122.24221435@xeon-e3>
Date:   Wed, 31 Oct 2018 08:31:22 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "Yoann P." <yoann.p.public@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute] ss: Actually print left delimiter for columns

On Mon, 29 Oct 2018 23:04:25 +0100
Stefano Brivio <sbrivio@...hat.com> wrote:

> While rendering columns, we use a local variable to keep track of the
> field currently being printed, without touching current_field, which is
> used for buffering.
> 
> Use the right pointer to access the left delimiter for the current column,
> instead of always printing the left delimiter for the last buffered field,
> which is usually an empty string.
> 
> This fixes an issue especially visible on narrow terminals, where some
> columns might be displayed without separation.
> 
> Reported-by: YoyPa <yoann.p.public@...il.com>
> Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> Tested-by: YoyPa <yoann.p.public@...il.com>

Looks good, applied.