netdev - Re: [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE active/inactive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181031094143.3fe008fc@xeon-e3>
Date:   Wed, 31 Oct 2018 09:41:43 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Leslie Monis <lesliemonis@...il.com>
Cc:     jhs@...atatu.com, netdev@...r.kernel.org, tahiliani@...k.edu.in,
        dhavaljkhandla26@...il.com, hrishihiraskar@...il.com,
        bmanish15597@...il.com, sdp.sachin@...il.com
Subject: Re: [PATCH net-next 6/8] net: sched: pie: add mechanism to set PIE
 active/inactive

On Wed, 31 Oct 2018 21:49:30 +0530
Leslie Monis <lesliemonis@...il.com> wrote:

> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index c84e91e..b68b367 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -57,6 +57,7 @@ struct pie_vars {
>  	psched_time_t dq_tstamp;	/* drain rate */
>  	u32 avg_dq_rate;	/* bytes per pschedtime tick,scaled */
>  	u32 qlen_old;		/* in bytes */
> +	bool active;		/* inactive/active */
>  };

Current Linux best practice is to not use bool for true/false values
in a structure. This is because the size of bool is not obvious and
can cause padding.

Recommend using u8 instead.