netdev - Re: Help with the BPF verifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181101191310.GB20495@kernel.org>
Date:   Thu, 1 Nov 2018 16:13:10 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     yhs@...com, daniel@...earbox.net, jolsa@...hat.com, kafai@...com,
        alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: Help with the BPF verifier

Em Thu, Nov 01, 2018 at 12:10:39PM -0700, David Miller escreveu:
> From: Arnaldo Carvalho de Melo <acme@...nel.org>
> Date: Thu, 1 Nov 2018 15:52:17 -0300
> 
> >     50		unsigned int filename_arg = 6;
>  ...
> > --- /wb/augmented_raw_syscalls.c.old	2018-11-01 15:43:55.000394234 -0300
> > +++ /wb/augmented_raw_syscalls.c	2018-11-01 15:44:15.102367838 -0300
> > @@ -67,7 +67,7 @@
> >  		augmented_args.filename.reserved = 0;
> >  		augmented_args.filename.size = probe_read_str(&augmented_args.filename.value,
> >  							      sizeof(augmented_args.filename.value),
> > -							      (const void *)args->args[0]);
> > +							      (const void *)args->args[filename_arg]);
> 
> args[] is sized to '6', therefore the last valid index is '5', yet you're using '6' here which
> is one entry past the end of the declared array.

Nope... this is inside an if:

        if (filename_arg <= 5) {
                augmented_args.filename.reserved = 0;
                augmented_args.filename.size = probe_read_str(&augmented_args.filename.value,
                                                              sizeof(augmented_args.filename.value),
                                                              (const void *)args->args[filename_arg]);
                if (augmented_args.filename.size < sizeof(augmented_args.filename.value)) {
                        len -= sizeof(augmented_args.filename.value) - augmented_args.filename.size;
                        len &= sizeof(augmented_args.filename.value) - 1;
                }
        } else {

I use 6 to mean "hey, this syscall doesn't have any string argument, don't
bother with it".

- Arnaldo