netdev - Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1541172486.4849.23.camel@debian.org>
Date:   Fri, 02 Nov 2018 15:28:06 +0000
From:   Luca Boccassi <bluca@...ian.org>
To:     Edward Cree <ecree@...arflare.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, dsahern@...il.com
Subject: Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage

On Fri, 2018-11-02 at 15:19 +0000, Edward Cree wrote:
> On 02/11/18 10:57, Luca Boccassi wrote:
> > ". If" gets interpreted as a macro, so move the period to the
> > previous
> > line:
> > 
> >   33: warning: macro `If' not defined
> > 
> > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
> > 
> > Signed-off-by: Luca Boccassi <bluca@...ian.org>
> > ---
> >  man/man8/tc-skbprio.8 | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8
> > index 844bbf46..8b259839 100644
> > --- a/man/man8/tc-skbprio.8
> > +++ b/man/man8/tc-skbprio.8
> > @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
> >  .B skb->priority
> >  is assigned. A typical use case is to copy
> >  the 6-bit DS field of IPv4 and IPv6 packets using
> > -.BR tc-skbedit (8)
> > -. If
> > +.BR tc-skbedit (8) .
> > +If
> 
> Won't that make the full-stop bold?
> Removing the space, i.e.
> .BR rc-skbedit (8).
> ought to work.
> -Ed

Yes you are right, fixed in v2, thanks.

-- 
Kind regards,
Luca Boccassi
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)