netdev - Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181103.154028.1864906755289829872.davem@davemloft.net>
Date:   Sat, 03 Nov 2018 15:40:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com, willemb@...gle.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 31 Oct 2018 08:39:11 -0700

> While BQL bulk dequeue works well for TSO packets, it is
> not very efficient as soon as GSO is involved.
> 
> On a GSO only workload (UDP or TCP), this patch series
> can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC,
> by keeping optimal batching, and avoiding expensive
> doorbells, qdisc requeues and reschedules.
> 
> This patch series :
> 
> - Add __netdev_tx_sent_queue() so that drivers
>   can implement efficient BQL and xmit_more support.
> 
> - Implement a work around in dev_hard_start_xmit()
>   for drivers not using __netdev_tx_sent_queue()
> 
> - changes mlx4 to use __netdev_tx_sent_queue()
> 
> v2: Tariq and Willem feedback addressed.
>     added __netdev_tx_sent_queue() (Willem suggestion)

Series applied, but I wonder how many other commonly used drivers we
should update the same way mlx4 is here?