netdev - Re: [PATCH net] net-sysfs: fix formatting of tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181103.193106.716765490044215561.davem@davemloft.net>
Date:   Sat, 03 Nov 2018 19:31:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jwi@...ux.ibm.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net-sysfs: fix formatting of tx_timeout attribute

From: Julian Wiedmann <jwi@...ux.ibm.com>
Date: Fri,  2 Nov 2018 19:33:17 +0100

> Add a missing newline.
> 
> Signed-off-by: Julian Wiedmann <jwi@...ux.ibm.com>
> ---
>  net/core/net-sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index bd67c4d0fcfd..ef06409d768e 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -1039,7 +1039,7 @@ static ssize_t tx_timeout_show(struct netdev_queue *queue, char *buf)
>  	trans_timeout = queue->trans_timeout;
>  	spin_unlock_irq(&queue->_xmit_lock);
>  
> -	return sprintf(buf, "%lu", trans_timeout);
> +	return sprintf(buf, "%lu\n", trans_timeout);

Maybe use 'fmt_ulong' instead?