netdev - Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181104.164420.752189312386852625.davem@davemloft.net>
Date:   Sun, 04 Nov 2018 16:44:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     holger@...lied-asynchrony.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

From: Andrew Lunn <andrew@...n.ch>
Date: Sun, 4 Nov 2018 19:47:41 +0100

> On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote:
>> Since 4.19 the following error in sysfs has appeared when using the
>> r8169 NIC driver:
>> 
>> $cd /sys/module/realtek/drivers
>> $ls -l
>> ls: cannot access 'mdio_bus:RTL8201F 10/100Mbps Ethernet': No such file or directory
>> [..garbled dir entries follow..]
>> 
>> Apparently the forward slash in "10/100Mbps Ethernet" is interpreted
>> as directory separator that leads nowhere, and was introduced in commit
>> 513588dd44b ("net: phy: realtek: add RTL8201F phy-id and functions").
>> 
>> Fix this by removing the offending slash in the driver name.
>> 
>> Other drivers in net/phy seem to have the same problem, but I cannot
>> test/verify them.
> 
> Hi Holger
> 
> This last comment would generally be placed after the ---. It will
> then not appear in the commit message.
> 
> Also, in future, please put the target tree, net or net-next as part
> of the subject line:
> 
> [PATCH net] ....

This didn't apply cleanly, something mangled the patch.

But I fixed it up and queued this up for -stable.