netdev - Re: [PATCH] net: skbuff.h: remove unnecessary unlikely()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEExFWuGN_R=7B4ueAVA8hVoix8ko8zQSXzHxZB5gjwP7jOjpg@mail.gmail.com>
Date:   Mon, 5 Nov 2018 21:21:50 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     davem@...emloft.net, Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>, dja@...ens.net,
        ast@...nel.org, sbrivio@...hat.com, pabeni@...hat.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: skbuff.h: remove unnecessary unlikely()

add netdev@...r.kernel.org
-- Yangtao
On Sun, Nov 4, 2018 at 9:14 PM Yangtao Li <tiny.windzz@...il.com> wrote:
>
> WARN_ON() already contains an unlikely(), so it's not necessary to use
> unlikely.
>
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  include/linux/skbuff.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 0ba687454267..7dcfb5591dc3 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -2508,10 +2508,8 @@ int ___pskb_trim(struct sk_buff *skb, unsigned int len);
>
>  static inline void __skb_set_length(struct sk_buff *skb, unsigned int len)
>  {
> -       if (unlikely(skb_is_nonlinear(skb))) {
> -               WARN_ON(1);
> +       if (WARN_ON(skb_is_nonlinear(skb)))
>                 return;
> -       }
>         skb->len = len;
>         skb_set_tail_pointer(skb, len);
>  }
> --
> 2.17.0
>