netdev - Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181105.112735.2095940458004008995.davem@davemloft.net>
Date:   Mon, 05 Nov 2018 11:27:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     jgg@...lanox.com, netdev@...r.kernel.org, eric.dumazet@...il.com,
        eranbe@...lanox.com, leonro@...lanox.com, arnd@...db.de,
        akpm@...ux-foundation.org
Subject: Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not
 required

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Mon, 5 Nov 2018 19:13:59 +0000

> On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote:
>> From: Saeed Mahameed <saeedm@...lanox.com>
>> Date: Fri,  2 Nov 2018 18:54:22 -0700
>> 
>> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct
>> > rtnl_link_stats64 *s)
>> > +{
>> > +	int i;
>> > +
>> > +	/* not required ? */
>> > +	memset(s, 0, sizeof(*s));
>> 
>> Why wouldn't this be required?
>> 
> 
> I just checked it is already done by the stack @dev_get_stats()

Then please document this in the commit message or similar.