netdev - Re: [PATCH net-next 0/5] net: dsa: bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7ebd795-3328-ecb2-cb02-cf8fa51e1570@gmail.com>
Date:   Tue, 6 Nov 2018 15:09:04 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, pablo@...filter.org
Subject: Re: [PATCH net-next 0/5] net: dsa: bcm_sf2: Store rules in lists

On 11/6/18 3:06 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Tue,  6 Nov 2018 12:58:36 -0800
> 
>> Hi all,
>>
>> This patch series changes the bcm-sf2 driver to keep a copy of the
>> inserted rules as opposed to using the HW as a storage area for a number
>> of reasons:
>>
>> - this helps us with doing duplicate rule detection in a faster way, it
>>   would have required a full rule read before
>>
>> - this helps with Pablo's on-going work to convert ethtool_rx_flow_spec
>>   to a more generic flow rule structure by having fewer code paths to
>>   convert to the new structure/helpers
>>
>> - we need to cache copies to restore them during drive resumption,
>>   because depending on the low power mode the system has entered, the
>>   switch may have lost all of its context
> 
> Looks good to me, series applied and build testing right now.
> 
> I will say that the ethtool flow spec comparison should probably
> eventually be broken out into a helper function places somewhere
> common.  It's very likely this approach, and thus the helper, can
> be used by other drivers in a similar situation.

Sure, that could be done, I will check with Pablo how he wants to
approach that as well since he is reworking how flow rules are
represented. Thanks!
-- 
Florian