netdev - Re: [PATCH net-next 01/11] udp: Handle ICMP errors for tunnels with same destination port on both endpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181106.152501.1178657449422714101.davem@davemloft.net>
Date:   Tue, 06 Nov 2018 15:25:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sbrivio@...hat.com
Cc:     sd@...asysnail.net, lucien.xin@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 01/11] udp: Handle ICMP errors for tunnels
 with same destination port on both endpoints

From: Stefano Brivio <sbrivio@...hat.com>
Date: Tue,  6 Nov 2018 22:38:57 +0100

> +	/* Network header needs to point to the outer IPv4 header inside ICMP */
> +	skb_reset_network_header(skb);
> +	iph = ip_hdr(skb);
> +	/* Transport header needs to point to the UDP header */
> +	skb_set_transport_header(skb, iph->ihl << 2);

Please put an empty line before the second comment.