netdev - [PATCH RFC net-next 2/3] net: phy: sfp: Issue warning when using Generic PHY driver(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181106232913.17216-3-f.fainelli@gmail.com>
Date:   Tue,  6 Nov 2018 15:29:12 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     andrew@...n.ch, rmk+kernel@...linux.org.uk, davem@...emloft.net,
        Florian Fainelli <f.fainelli@...il.com>
Subject: [PATCH RFC net-next 2/3] net: phy: sfp: Issue warning when using Generic PHY driver(s)

1000BaseT SFP modules typically include an Ethernet PHY device, and
while the Generic PHY driver will be able to bind to it, it usually will
not work at all without a specialized PHY driver. Issue a warning in
that case to help toubleshoot things.

Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
---
 drivers/net/phy/sfp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index fd8bb998ae52..228205d8ce84 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1203,6 +1203,9 @@ static void sfp_sm_probe_phy(struct sfp *sfp)
 	}
 
 	sfp->mod_phy = phy;
+	if (phy_driver_is_genphy(phy) || phy_driver_is_genphy_10g(phy))
+		dev_warn(sfp->dev, "Using Generic PHY driver with a SFP!\n");
+
 	phy_start(phy);
 }
 
-- 
2.17.1