netdev - Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Nov 2018 18:08:16 -0700
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, alexey.kodanev@...cle.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return
 value in rtnl_dump_all()

On 11/5/18 6:06 PM, David Miller wrote:
> From: Alexey Kodanev <alexey.kodanev@...cle.com>
> Date: Fri,  2 Nov 2018 19:11:04 +0300
> 
>> For non-zero return from dumpit() we should break the loop
>> in rtnl_dump_all() and return the result. Otherwise, e.g.,
>> we could get the memory leak in inet6_dump_fib() [1]. The
>> pointer to the allocated struct fib6_walker there (saved
>> in cb->args) can be lost, reset on the next iteration.
>>
>> Fix it by partially restoring the previous behavior before
>> commit c63586dc9b3e ("net: rtnl_dump_all needs to propagate
>> error from dumpit function"). The returned error from
>> dumpit() is still passed further.
>  ...
>> Fixes: c63586dc9b3e ("net: rtnl_dump_all needs to propagate error from dumpit function")
>> Signed-off-by: Alexey Kodanev <alexey.kodanev@...cle.com>
> 
> Applied.
> 

Lost track of these in the noise of the past few days.

Thanks for the fixes Alexey.