netdev - Re: [PATCH net-next v4 5/9] net: fix raw socket lookup device bind matching with VRFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d66a8ab0-a16d-c9c1-00ad-8442bd9c6de0@gmail.com>
Date:   Tue, 6 Nov 2018 11:08:33 -0700
From:   David Ahern <dsahern@...il.com>
To:     Mike Manning <mmanning@...tta.att-mail.com>, netdev@...r.kernel.org
Cc:     Duncan Eastoe <deastoe@...tta.att-mail.com>
Subject: Re: [PATCH net-next v4 5/9] net: fix raw socket lookup device bind
 matching with VRFs

since you are re-sending, a couple of nits ...

On 11/2/18 1:10 PM, Mike Manning wrote:
> diff --git a/include/net/raw.h b/include/net/raw.h
> index 20ebf0b3dfa8..6ed2ae5b4a80 100644
> --- a/include/net/raw.h
> +++ b/include/net/raw.h
> @@ -18,6 +18,7 @@
>  #define _RAW_H
>  
>  
> +#include <net/inet_sock.h>

Replace one of the extra newlines after '#define _RAW_H' with this new one.

>  #include <net/protocol.h>
>  #include <linux/icmp.h>
>  
> @@ -75,4 +76,15 @@ static inline struct raw_sock *raw_sk(const struct sock *sk)
>  	return (struct raw_sock *)sk;
>  }
>  
> +static inline bool raw_sk_bound_dev_eq(struct net *net, int bound_dev_if,
> +				       int dif, int sdif)
> +{
> +#if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV)
> +	return inet_bound_dev_eq(net->ipv4.sysctl_raw_l3mdev_accept,
> +				 bound_dev_if, dif, sdif);

!!net->ipv4.sysctl_raw_l3mdev_accept