netdev - Re: [PATCH net] net: bpfilter: fix iptables failure if bpfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181105.171321.294466712176893792.davem@davemloft.net>
Date:   Mon, 05 Nov 2018 17:13:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     netdev@...r.kernel.org, daniel@...earbox.net, ast@...nel.org,
        pablo@...filter.org, fw@...len.de
Subject: Re: [PATCH net] net: bpfilter: fix iptables failure if
 bpfilter_umh is disabled

From: Taehee Yoo <ap420073@...il.com>
Date: Mon,  5 Nov 2018 22:31:41 +0900

> When iptables command is executed, ip_{set/get}sockopt() try to upload
> bpfilter.ko if bpfilter is enabled. if it couldn't find bpfilter.ko,
> command is failed.
> bpfilter.ko is generated if CONFIG_BPFILTER_UMH is enabled.
> ip_{set/get}sockopt() only checks CONFIG_BPFILTER.
> So that if CONFIG_BPFILTER is enabled and CONFIG_BPFILTER_UMH is disabled,
> iptables command is always failed.
> 
> test config:
>    CONFIG_BPFILTER=y
>    # CONFIG_BPFILTER_UMH is not set
> 
> test command:
>    %iptables -L
>    iptables: No chain/target/match by that name.
> 
> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied, thanks Taehee-ssi.