netdev - Re: [PATCH net-next v5 4/9] net: provide a sysctl raw_l3mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05dd6127-34e5-9872-ac86-74520e1fd943@gmail.com>
Date:   Wed, 7 Nov 2018 12:07:01 -0700
From:   David Ahern <dsahern@...il.com>
To:     Mike Manning <mmanning@...tta.att-mail.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 4/9] net: provide a sysctl raw_l3mdev_accept
 for raw socket lookup with VRFs

On 11/7/18 8:36 AM, Mike Manning wrote:
> Add a sysctl raw_l3mdev_accept to control raw socket lookup in a manner
> similar to use of tcp_l3mdev_accept for stream and of udp_l3mdev_accept
> for datagram sockets. Have this default to enabled for reasons of
> backwards compatibility. This is so as to specify the output device
> with cmsg and IP_PKTINFO, but using a socket not bound to the
> corresponding VRF. This allows e.g. older ping implementations to be
> run with specifying the device but without executing it in the VRF.
> If the option is disabled, packets received in a VRF context are only
> handled by a raw socket bound to the VRF, and correspondingly packets
> in the default VRF are only handled by a socket not bound to any VRF.
> 
> Signed-off-by: Mike Manning <mmanning@...tta.att-mail.com>
> ---
>  Documentation/networking/ip-sysctl.txt | 12 ++++++++++++
>  Documentation/networking/vrf.txt       | 13 +++++++++++++
>  include/net/netns/ipv4.h               |  3 +++
>  include/net/raw.h                      |  1 +
>  net/ipv4/af_inet.c                     |  2 ++
>  net/ipv4/raw.c                         | 28 ++++++++++++++++++++++++++--
>  net/ipv4/sysctl_net_ipv4.c             | 11 +++++++++++
>  7 files changed, 68 insertions(+), 2 deletions(-)

Reviewed-by: David Ahern <dsahern@...il.com>
Tested-by: David Ahern <dsahern@...il.com>