netdev - Re: [PATCH v4 1/3] net: emac: implement 802.1Q VLAN TX tagging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181107.112318.1682556084485571308.davem@davemloft.net>
Date:   Wed, 07 Nov 2018 11:23:18 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     chunkeey@...il.com
Cc:     netdev@...r.kernel.org, ivan@...ibm.com, f.fainelli@...il.com
Subject: Re: [PATCH v4 1/3] net: emac: implement 802.1Q VLAN TX tagging
 support

From: David Miller <davem@...emloft.net>
Date: Tue, 06 Nov 2018 15:09:54 -0800 (PST)

> From: Christian Lamparter <chunkeey@...il.com>
> Date: Tue,  6 Nov 2018 23:27:49 +0100
> 
>> @@ -1435,6 +1436,22 @@ static inline netdev_tx_t emac_xmit_finish(struct emac_instance *dev, int len)
>>  	return NETDEV_TX_OK;
>>  }
>>  
>> +static inline u16 emac_tx_vlan(struct emac_instance *dev, struct sk_buff *skb)
>> +{
>> +	/* Handle VLAN TPID and TCI insert if this is a VLAN skb */
>> +	if (emac_has_feature(dev, EMAC_FTR_HAS_VLAN_CTAG_TX) &&
>> +	    skb_vlan_tag_present(skb)) {
>> +		struct emac_regs __iomem *p = dev->emacp;
>> +
>> +		/* update the VLAN TCI */
>> +		out_be32(&p->vtci, (u32)skb_vlan_tag_get(skb));
> 
> Hmmm, how does this vtci register work?

I'm tossing your patches since you refuse to answer my question and
explain why this works properly.

Sorry.