netdev - Re: [PATCH bpf-next] bpf_load: add map name to load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c6eb7b1-9387-6400-b3d4-4ba185248e1b@iogearbox.net>
Date:   Wed, 7 Nov 2018 22:41:37 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Song Liu <liu.song.a23@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     shannon.nelson@...cle.com, Alexei Starovoitov <ast@...nel.org>,
        Networking <netdev@...r.kernel.org>, shannon.lee.nelson@...il.com
Subject: Re: [PATCH bpf-next] bpf_load: add map name to load_maps error
 message

On 11/07/2018 01:26 AM, Song Liu wrote:
> On Mon, Oct 29, 2018 at 3:12 PM John Fastabend <john.fastabend@...il.com> wrote:
>>
>> On 10/29/2018 02:14 PM, Shannon Nelson wrote:
>>> To help when debugging bpf/xdp load issues, have the load_map()
>>> error message include the number and name of the map that
>>> failed.
>>>
>>> Signed-off-by: Shannon Nelson <shannon.nelson@...cle.com>
>>> ---
>>>  samples/bpf/bpf_load.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c
>>> index 89161c9..5de0357 100644
>>> --- a/samples/bpf/bpf_load.c
>>> +++ b/samples/bpf/bpf_load.c
>>> @@ -282,8 +282,8 @@ static int load_maps(struct bpf_map_data *maps, int nr_maps,
>>>                                                       numa_node);
>>>               }
>>>               if (map_fd[i] < 0) {
>>> -                     printf("failed to create a map: %d %s\n",
>>> -                            errno, strerror(errno));
>>> +                     printf("failed to create map %d (%s): %d %s\n",
>>> +                            i, maps[i].name, errno, strerror(errno));
>>>                       return 1;
>>>               }
>>>               maps[i].fd = map_fd[i];
>>>
>>
>> LGTM
>>
>> Acked-by: John Fastabend <john.fastabend@...il.com>
> 
> Acked-by: Song Liu <songliubraving@...com>

Applied to bpf-next, thanks!