netdev - Re: [PATCH bpf] bpf: Fix IPv6 dport byte order in bpf_sk_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOftzPi01mMS+3O4spehnVw2V1D7BUHKJPD8DHkMZZyZ7bfAxg@mail.gmail.com>
Date:   Wed, 7 Nov 2018 13:51:31 -0800
From:   Joe Stringer <joe@...d.net.nz>
To:     rdna@...com
Cc:     netdev <netdev@...r.kernel.org>, ast@...nel.org,
        daniel@...earbox.net, Joe Stringer <joe@...d.net.nz>,
        kernel-team@...com
Subject: Re: [PATCH bpf] bpf: Fix IPv6 dport byte order in bpf_sk_lookup_udp

On Wed, 7 Nov 2018 at 13:37, Andrey Ignatov <rdna@...com> wrote:
>
> Lookup functions in sk_lookup have different expectations about byte
> order of provided arguments.
>
> Specifically __inet_lookup, __udp4_lib_lookup and __udp6_lib_lookup
> expect dport to be in network byte order and do ntohs(dport) internally.
>
> At the same time __inet6_lookup expects dport to be in host byte order
> and correspondingly name the argument hnum.
>
> sk_lookup works correctly with __inet_lookup, __udp4_lib_lookup and
> __inet6_lookup with regard to dport. But in __udp6_lib_lookup case it
> uses host instead of expected network byte order. It makes result
> returned by bpf_sk_lookup_udp for IPv6 incorrect.
>
> The patch fixes byte order of dport passed to __udp6_lib_lookup.
>
> Originally sk_lookup properly handled UDPv6, but not TCPv6. 5ef0ae84f02a
> fixes TCPv6 but breaks UDPv6.
>
> Fixes: 5ef0ae84f02a ("bpf: Fix IPv6 dport byte-order in bpf_sk_lookup")
> Signed-off-by: Andrey Ignatov <rdna@...com>

Thanks for the fix, makes sense.

Acked-by: Joe Stringer <joe@...d.net.nz>