netdev - Re: [PATCH mlx5-next 00/10] Collection of ODP fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Nov 2018 19:50:53 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Jason Gunthorpe <jgg@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Majd Dibbiny <majd@...lanox.com>,
        Moni Shoua <monis@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>,
        Artemy Kovalyov <artemyko@...lanox.com>
Subject: Re: [PATCH mlx5-next 00/10] Collection of ODP fixes

On Thu, 2018-11-08 at 19:45 +0000, Jason Gunthorpe wrote:
> On Thu, Nov 08, 2018 at 09:10:07PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@...lanox.com>
> > 
> > Hi,
> > 
> > This is collection of fixes to mlx5_core and mlx5_ib ODP logic.
> > There are two main reasons why we decided to forward it to mlx5-
> > next
> > and not to rdma-rc or net like our other fixes.
> > 
> > 1. We have large number of patches exactly in that area that are
> > ready
> > for submission and we don't want to create extra merge work for
> > maintainers due to that. Among those future series (already ready
> > and
> > tested): internal change of mlx5_core pagefaults handling, moving
> > ODP
> > code to RDMA, change in EQ mechanism, simplification and moving SRQ
> > QP
> > to RDMA, extra fixes to mlx5_ib ODP and ODP SRQ support.
> > 
> > 2. Most of those fixes are for old bugs and there is no rush to fix
> > them
> > right now (in -rc1/-rc2).
> > 
> > Thanks
> > 
> > Moni Shoua (10):
> >   net/mlx5: Release resource on error flow
> >   IB/mlx5: Avoid hangs due to a missing completion
> >   net/mlx5: Add interface to hold and release core resources
> >   net/mlx5: Enumerate page fault types
> >   IB/mlx5: Lock QP during page fault handling
> >   net/mlx5: Return success for PAGE_FAULT_RESUME in internal error
> > state
> >   net/mlx5: Use multi threaded workqueue for page fault handling
> >   IB/mlx5: Call PAGE_FAULT_RESUME command asynchronously
> >   net/mlx5: Remove unused function
> >   IB/mlx5: Improve ODP debugging messages
> > 
> >  drivers/infiniband/core/umem_odp.c            |  14 +-
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h          |   1 +
> >  drivers/infiniband/hw/mlx5/mr.c               |  15 +-
> >  drivers/infiniband/hw/mlx5/odp.c              | 158
> > ++++++++++++++----
> >  drivers/net/ethernet/mellanox/mlx5/core/cmd.c |   2 +-
> >  drivers/net/ethernet/mellanox/mlx5/core/eq.c  |  21 +--
> >  drivers/net/ethernet/mellanox/mlx5/core/qp.c  |  20 ++-
> 
> there is alot of ethernet files here, parts of this should probably
> go
> through the shared branch?
> 

All of this should go to the shared branch, 
after this ODP series we have another series that moves all the ODP
logic out of mlx5_core into mlx5_ib.

> Jason