netdev - Re: [Patch net-next] net: move __skb_checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpV5jRUUTByS0d++jAw-5MMDxx-O4W9PC58-qWaHUeN0ng@mail.gmail.com>
Date:   Thu, 8 Nov 2018 12:26:00 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [Patch net-next] net: move __skb_checksum_complete*() to skbuff.c

On Thu, Nov 8, 2018 at 12:14 PM Stefano Brivio <sbrivio@...hat.com> wrote:
>
> On Thu, 8 Nov 2018 12:02:00 -0800
> Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> > On Thu, Nov 8, 2018 at 11:54 AM Stefano Brivio <sbrivio@...hat.com> wrote:
> > >
> > > Hi,
> > >
> > > On Thu,  8 Nov 2018 11:49:49 -0800
> > > Cong Wang <xiyou.wangcong@...il.com> wrote:
> > >
> > > > +EXPORT_SYMBOL(__skb_checksum_complete);
> > > > +
> > > >  /* Both of above in one bottle. */
> > >
> > > Maybe you should also update/drop this comment now?
> >
> > I have no idea what that comment means. Do you?
>
> I think it refers to the fact that skb_copy_and_csum_bits() implements
> both skb_checksum() and skb_copy_bits(), that were just above it at
> 1da177e4c3f4.
>
> Then more stuff was moved in between, and the comment was never updated
> or dropped.

I don't want to touch what I don't understand. So, let me just move
these two after skb_copy_and_csum_bits().