netdev - Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2iCea-d9duHtakUx7BFgZuFgp92vejpss2eBboZ-ybwg@mail.gmail.com>
Date:   Thu, 8 Nov 2018 22:02:25 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Sunil Kovvuri <sunil.kovvuri@...il.com>
Cc:     Networking <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, linux-soc@...r.kernel.org,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling

On Thu, Nov 8, 2018 at 7:36 PM <sunil.kovvuri@...il.com> wrote:
>
> From: Sunil Goutham <sgoutham@...vell.com>

Hmm, I noticed that you use a different address as the patch author
and the submitter. I'm guessing that "Sunil Goutham" and
"Sunil Kovvuri" actually refer to the same person, and you just
need to pick which of the two email addresses you want to use
for public communication, but that's not obvious here.

However, if there are actually two different Sunil's here, then
you need to add that second Signed-off-by.

I've taken a look at all the patches now, and found very little
sticking out that warranted a comment from my side, and
no real show-stoppers. That said, I found this series overall
much harder to understand than the previous ones, and don't
even know what to ask about it. My feeling is that it's probably
all fine, but that is  purely based on a review  of the individual
pieces, not the overall design and how they fit together. With the
earlier patches that I managed to get a better understanding
of, that seemed reasonable as well.

      Arnd