netdev - Re: [PATCH net-next 0/4] Remove VLAN_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181108221145.GA11538@qmqm.qmqm.pl>
Date:   Thu, 8 Nov 2018 23:11:45 +0100
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     netdev@...r.kernel.org, Claudiu Manoil <claudiu.manoil@....com>,
        Faisal Latif <faisal.latif@...el.com>,
        Pravin B Shelar <pshelar@....org>,
        Shiraz Saleem <shiraz.saleem@...el.com>, dev@...nvswitch.org,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers

On Thu, Nov 08, 2018 at 08:50:05PM +0200, Leon Romanovsky wrote:
> On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote:
> > This series removes VLAN_TAG_PRESENT use from network drivers in
> > preparation to removing its special meaning.
> Can you please give an extra explanation why it is removed?
> Such series come out-of-blue, for people who are not following
> netdev mailing list closely (drivers/infiniband/*).

This is one of the steps to remove VLAN_TAG_PRESENT overlap with CFI/DEI
bit of VLAN tag. Currently this overlap causes Linux kernel to always
clear CFI/DEI in packets.

There is skb_vlan_tag_present() that drivers should use to check if
the tag in skb is valid.

Best Regards,
Michał Mirosław