netdev - Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181108.151540.1050553509106510974.davem@davemloft.net>
Date:   Thu, 08 Nov 2018 15:15:40 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     amritha.nambiar@...el.com
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        sridhar.samudrala@...el.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets
 using port ranges

From: Amritha Nambiar <amritha.nambiar@...el.com>
Date: Wed, 07 Nov 2018 13:22:42 -0800

> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index 401d0c1..b63c3cf 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -405,6 +405,11 @@ enum {
>  	TCA_FLOWER_KEY_UDP_SRC,		/* be16 */
>  	TCA_FLOWER_KEY_UDP_DST,		/* be16 */
>  
> +	TCA_FLOWER_KEY_PORT_SRC_MIN,	/* be16 */
> +	TCA_FLOWER_KEY_PORT_SRC_MAX,	/* be16 */
> +	TCA_FLOWER_KEY_PORT_DST_MIN,	/* be16 */
> +	TCA_FLOWER_KEY_PORT_DST_MAX,	/* be16 */
> +
>  	TCA_FLOWER_FLAGS,
>  	TCA_FLOWER_KEY_VLAN_ID,		/* be16 */
>  	TCA_FLOWER_KEY_VLAN_PRIO,	/* u8   */
> @@ -518,6 +523,8 @@ enum {

I don't think you can do this without breaking UAPI, this changes the
value of TCA_FLOWER_FLAGS and all subsequent values in this
enumeration.