netdev - Re: [PATCH iproute2] tc: f_u32: allow skip_hw and skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181109081304.09e0d040@xeon-e3>
Date:   Fri, 9 Nov 2018 08:13:04 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2] tc: f_u32: allow skip_hw and skip_sw flags to
 be last

On Mon,  5 Nov 2018 19:23:27 -0800
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> u32 uses NEXT_ARG() incorrectly when parsing skip_hw and skip_sw
> flags.  NEXT_ARG() ensures there is another argument on the command
> line, and is used in handling <keyword> <value> syntax to move past
> <keyword> and ensure there is a <value> to read.
> 
> Commit 5e5b3008d1fb ("tc: f_u32: Add support for skip_hw and skip_sw
> flags") seems to have copy pasted the handling from the previous
> command - "police", which needs an extra parameter and is kind of
> special due to the use of parse_police() helper.
> 
> The combination of NEXT_ARG() and continue worked fine as long as
> skip_sw/skip_hw wasn't last, e.g.:
> 
> $ tc filter add dev dummy0 ingress prio 101 protocol ipv6 \
>     u32 match ip6 priority 0xa0 0xe0 skip_hw action pass
> 
> But would fail if it was last:
> 
> $ tc filter add dev dummy0 ingress prio 101 protocol ipv6 \
>     u32 match ip6 priority 0xa0 0xe0 flowid :1 skip_hw
> Command line is not complete. Try option "help"
> 
> Remove the NEXT_ARG()s and the continues, and let the argc--; argv++;
> at the end of the loop do its job.
> 
> Fixes: 5e5b3008d1fb ("tc: f_u32: Add support for skip_hw and skip_sw flags")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied